Skip to content
This repository has been archived by the owner on Mar 4, 2023. It is now read-only.

Beginnings of Economy page #10

Closed
wants to merge 8 commits into from
Closed

Conversation

ice-fly
Copy link

@ice-fly ice-fly commented May 20, 2020

  1. Begin resolving Add economy page #1
  2. Added images

ice-fly added 5 commits May 19, 2020 22:38
Add sign creation images for Eco page
* Create Economy.md

Begin resolving #1
Referenced old essentials wiki. Added new config options with their explanation. Added how to use signs with economy.

Still needs: Explain how to use an alternative economy plugin

* Add images for Eco Page

Two images:
1. Shows what is typed
2. Shows the resulting Buy/Sell sign

* Update Economy.md
Changed images to refrence EssX wiki in expectation of pull accepted
ice-fly added 2 commits May 20, 2020 22:33
Used `inline code` for all refrences to config-yml names.
Resized & moved images to example section.
Re-added multiline code section about sign formatting *(Still not certain on best way to communicate the format)*
Fix images through use of table & minor formatting
@ice-fly ice-fly marked this pull request as ready for review May 21, 2020 02:50
Copy link
Member

@mdcfe mdcfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this documentation! I've left a few comments where I've got concerns about the content, but so far it looks good.

@@ -0,0 +1,93 @@
# EssentialsX Economy
The built in economy API will redirect to any other detected economy system such as vault. This means you can use EssEco api as a economy api instead of vault if your plugin is dependent on Essentials.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the start of the page should explain what the economy is, perhaps something like "EssentialsX comes with a simple, easy-to-use economy system built into the plugin." or similar?

This part about the API should probably be in a separate section at the bottom, since it's only useful to developers and doesn't mean much to most people who want to use EssentialsX.

(Also tiny nitpicks: "vault" should be "Vault", "EssEco" should be "EssentialsX's economy", "api" should be "API")

Economy.md Show resolved Hide resolved
Economy.md Show resolved Hide resolved
Economy.md Show resolved Hide resolved
Economy.md Show resolved Hide resolved
Economy.md Show resolved Hide resolved
Comment on lines +75 to +89
#### Signs
To create a sign, ensure that you have the `signs.create.trade` permission and that you have uncommented `- buy` and `- sell` under `enabledSigns:` in the config.yml
Signs follow the format:
```
[Buy]/[Sell]
Quantity
[Material](https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Material.html)
Cost
```
###### Example:
What is typed into the sign UI | Essentials will turn the `[Buy]`/`[Sell]` blue when done sucessfully
:-------------------------------:|:-------------------------------:
| ![Image of Sign Creation UI](/images/EcoBuySignUI.png?v=4&s=360) | ![Image of Completed Buy/Sell Signs](/images/EcoBuySellSign.png?v=4&s=400) |

The sign will allow players with the `signs.use.buy` permission to purchase 1 dirt for $1 when left clicked. If `[Buy]` is changed to `[Sell]` and the player has the respective permission, the player may sell 1 dirt to the server in exchange for $1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signs are already explained on the old original Essentials wiki, and it thoroughly explains all the signs already (including [trade] which is missing here). I'd prefer it if this section just mentions that [trade], [buy] and [sell] exist and then linked to that page. We can add our own page for signs later down the line.

Comment on lines +90 to +93
#### Shops
To prevent players exploiting the the economy by purchasing from the server using a buy sign and `/sell`, only create Buy signs at or above the rates found in `worth.yml`.
A good server shop typically offers bulk Sell signs at better rates than the `worth.yml` to encourage players to use the shop over `/sell`.
Alternatively, if players aren't given the `essentials.sell` permission, their only option is to trade between players or go to the shop.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be replaced by a section explaining /setworth, /worth and /sell. The bit about sign shops should be included in the sign shops section.

Economy.md Show resolved Hide resolved
## Signs & Shops
Signs may be used to create shops where players can buy and sell items/blocks to and from the server in exchange for money.
#### Signs
To create a sign, ensure that you have the `signs.create.trade` permission and that you have uncommented `- buy` and `- sell` under `enabledSigns:` in the config.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The essentials.signs.<action>.trade permissions are for the [trade] sign, which this section doesn't actually explain. The buy and sell permissions are for the [buy] and [sell] signs respectively. This also doesn't explain that players need to be given permissions to use the signs too, or that creating [buy] and [sell] should be limited to admins only.

@osfanbuff63 osfanbuff63 mentioned this pull request Feb 26, 2022
@mdcfe
Copy link
Member

mdcfe commented Oct 31, 2022

Hey there, we're deprecating this repository in favour of https://github.com/EssentialsX/Website. The content from this repository has moved to the pages/wiki directory in that repo.

Since this PR seems to be abandoned and #23 replaces it, I'm going to close this.

@mdcfe mdcfe closed this Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants