-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Enable GitHub Actions based CI #55
Conversation
a9906a7
to
6233535
Compare
Also removes 1.15 because of a bug in archloom ([1]). Diff between 1.16.2-forge before and after the removal shows no significant changes. [1]: architectury/architectury-loom#151
6233535
to
f40ddc5
Compare
our publish plugin expects them as project properties because that's where they used to be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason this caused a maven publish with the branch name HEAD
is that pull_request
triggers are based on the merge commit for the PR, so the branch name isn't associated. We'll probably need some override (env variable?) in EGT that actions can pass through from github.event.pull_request.head.ref
.
.github/workflows/main.yml
Outdated
key: gradle-wrapper-${{ hashFiles('**/gradle-wrapper.properties') }} | ||
- uses: actions/cache@v3 | ||
with: | ||
path: ~/.gradle/caches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also cache the loom-cache
folders in the project, this contains remapped mods and MC versions with AW/ATs applied (only the first is relevant to our mods though). See Sk1erLLC/Patcher#72
Hm, looks like that's the case. I expected it to use something like |
Also removes 1.15 because of a bug in archloom (1).
Diff between 1.16.2-forge before and after the removal shows no significant
changes:
To be squashed on merge.
Publish doesn't work yet due to secrets not being set up, but otherwise should be good to review.