Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a new ItemTypes array #1724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add a new ItemTypes array #1724

wants to merge 1 commit into from

Conversation

vivzhang
Copy link
Contributor

@vivzhang vivzhang commented Nov 7, 2024

affects: @esri/hub-common

  1. Description:

Add new a ItemTypes array with a list of item type objects in types.ts

  1. Instructions for testing:

  2. Closes Issues: # (if appropriate)

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

affects: @esri/hub-common
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2626a26) to head (d808f12).
Report is 160 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #1724    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          992      1030    +38     
  Lines        17979     18665   +686     
  Branches      3199      3377   +178     
==========================================
+ Hits         17979     18665   +686     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant