Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(linting): enable radix rule #11098

Merged
merged 2 commits into from
Jan 1, 2025
Merged

chore(linting): enable radix rule #11098

merged 2 commits into from
Jan 1, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 18, 2024 •
edited
Loading

Related Issue: N/A

Summary

Enables the radix rule to ban unnecessary usage of radix when using parseInt:

On the other hand, if the code is targeting only ES5-compliant environments passing the radix 10 may be redundant. In such a case you might want to disallow using such a radix.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Dec 18, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Dec 26, 2024
@jcfranco jcfranco requested review from driskull and benelan December 31, 2024 17:58
@jcfranco jcfranco marked this pull request as ready for review December 31, 2024 17:58
driskull
driskull approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit a11a496 into dev Jan 1, 2025
9 checks passed
@jcfranco jcfranco deleted the jcfranco/enable-radix-rule branch January 1, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@benelan benelan Awaiting requested review from benelan

Assignees

@jcfranco jcfranco

Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull