docs: deprecate add custom-content slot for dialog component #11072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto dit13711/10323-rename-dialog-content-slot
…nto dit13711/10323-rename-dialog-content-slot
driskull
requested changes
Dec 16, 2024
| @@ -50,7 +50,8 @@ let initialDocumentOverflowStyle: string = ""; | |||
|
|
|||
| /** | |||
| * @slot - A slot for adding content. | |||
| * @slot content - A slot for adding custom content. | |||
| * @slot content - [Deprecated] Use `custom-content` slot instead. | |||
There was a problem hiding this comment.
@DitwanP we would actually need to add this slot in the code. It not just a doc change.
I'm kinda unsure how this change would work without being breaking since we put the panel inside the content slot by default.
There was a problem hiding this comment.
@driskull Yeah good point. That being said, what are your thoughts on changing the slot to the new one overall? Are you in favor or not in favor of such a change?
There was a problem hiding this comment.
I'm in favor of it, i'm just not sure how it will work exactly.
There was a problem hiding this comment.
Can this coincide with the rest of 3.0 breaking changes?
There was a problem hiding this comment.
Thats a question for @jcfranco
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10323
Summary
Deprecates the
"content"slot in favor of a new"custom-content"slot that will clearly describes the behavior that a user can expect. This change should solve the issue of confusion that we've heard about from internal feedback.The description of the new slot would be: