-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(accordion-item): update token naming schema #11070
Conversation
…d --calcite-accordion-item-start-icon-color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM! Let’s use feat
since this introduces new props. For the deprecations, please refer to the second part of the deprecation PR section in the PR review guidelines to add a separate changelog entry.
Could you also update the conventional commit description in the PR title to use the imperative, present tense? The imperative part was referenced before in our conventions, but it’s not explicitly listed now. I’ll make sure to update that today.
@alisonailea Sorry, I should've been more specific. You'll need to use a commit override in the PR description to include both
@DitwanP Can you confirm? |
Related Issue: #10894
Summary
This PR adds two new tokens which align with the Calcite naming schema.
--calcite-accordion-item-icon-color-start
--calcite-accordion-item-icon-color-end
BEGIN_COMMIT_OVERRIDE
deprecate(accordion-item): deprecate
--calcite-accordion-item-start-icon-color
and--calcite-accordion-item-end-icon-color
tokensEND_COMMIT_OVERRIDE