Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion-item): update token naming schema #11070

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

alisonailea
Copy link
Contributor

@alisonailea alisonailea commented Dec 16, 2024

Related Issue: #10894

Summary

This PR adds two new tokens which align with the Calcite naming schema.

--calcite-accordion-item-icon-color-start
--calcite-accordion-item-icon-color-end

BEGIN_COMMIT_OVERRIDE
deprecate(accordion-item): deprecate --calcite-accordion-item-start-icon-color and --calcite-accordion-item-end-icon-color tokens
END_COMMIT_OVERRIDE

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Dec 16, 2024
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM! Let’s use feat since this introduces new props. For the deprecations, please refer to the second part of the deprecation PR section in the PR review guidelines to add a separate changelog entry.

Could you also update the conventional commit description in the PR title to use the imperative, present tense? The imperative part was referenced before in our conventions, but it’s not explicitly listed now. I’ll make sure to update that today.

@alisonailea alisonailea changed the title chore(accordion-item): Accordion icon token naming schema feat(accordion-item): Accordion icon token naming schema Dec 16, 2024
@alisonailea alisonailea changed the title feat(accordion-item): Accordion icon token naming schema feat(accordion-item): update token naming schema Dec 16, 2024
@jcfranco
Copy link
Member

For the deprecations, please refer to the second part of the deprecation PR section in the PR review guidelines to add a separate changelog entry.

@alisonailea Sorry, I should've been more specific. You'll need to use a commit override in the PR description to include both feat and deprecate entries. Something like the following:

BEGIN_COMMIT_OVERRIDE
feat(accordion-item): update token naming schema
deprecate(accordion-item): deprecate start/end icon color CSS props
END_COMMIT_OVERRIDE

@DitwanP Can you confirm?

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Dec 23, 2024
@alisonailea alisonailea added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 23, 2024
@alisonailea alisonailea merged commit d624985 into dev Dec 23, 2024
18 checks passed
@alisonailea alisonailea deleted the astump/10894-accordion-item-token-names branch December 23, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants