Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManageOperationalLayers fixes #1495

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

williambohrmann3
Copy link
Collaborator

Description

  • Resolves a bug which prevented the visibility of the excluded layers list.
    • Accomplishes this by moving to CollectionView.
  • Uses Calcite UI icons for buttons.
  • Adds clarity to sample directions.

Note on promotion and demotion of layers

Promote and demote language now refers to the draw order, not where the layer falls in the vertical hierarchy of the list view. This change is complimented by changes in the button icons. If we want to ditch the promote/demote terminology, perhaps we can go with something like "bring forward" and "push backward".

Type of change

  • Bug fix

Platforms tested on

  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@williambohrmann3 williambohrmann3 self-assigned this Jul 24, 2024
@cgutierrez-gis
Copy link
Collaborator

testing the branch for this fix now

@cgutierrez-gis
Copy link
Collaborator

Testing locally in both release and debug configuration on Mac catalyst worked fine for me 👌

@williambohrmann3 williambohrmann3 merged commit ee249ea into main Jul 29, 2024
6 checks passed
@williambohrmann3 williambohrmann3 deleted the wbohr/ManageOperationalLayers branch July 29, 2024 16:51
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants