Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code not displaying #1492

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

williambohrmann3
Copy link
Collaborator

@williambohrmann3 williambohrmann3 commented Jul 23, 2024

Description

  • Fixes paths to .xaml and .cs files which are used in the source code viewer. Only "Network analysis" and "Utility network" samples are impacted by this bug (iOS / Android).
  • Adds MauiAssets for .xaml files, removing need for Android platform code. This fixes FileNotFound exception for Release config on Android.

Type of change

  • Bug fix

Platforms tested on

  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • No unrelated changes have been made to any other code or project files

Copy link
Collaborator

@cgutierrez-gis cgutierrez-gis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@duffh duffh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

@williambohrmann3 williambohrmann3 changed the title Use PascalCase for categories in file path Source code not displaying Jul 26, 2024
@cgutierrez-gis
Copy link
Collaborator

cgutierrez-gis commented Jul 26, 2024

@williambohrmann3 Have tested the latest fix accounting for the missing XAML code files on my end and it has been resolved. Looks good!

@williambohrmann3 williambohrmann3 merged commit f180498 into main Jul 29, 2024
6 checks passed
@williambohrmann3 williambohrmann3 deleted the wbohr/case-sensitive-file-paths branch July 29, 2024 16:43
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants