Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MAUI build on v.next #1284

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Fix MAUI build on v.next #1284

merged 1 commit into from
Aug 11, 2023

Conversation

duffh
Copy link
Collaborator

@duffh duffh commented Aug 11, 2023

Description

The MAUI sample viewer wasn't building, this has been fixed.

Type of change

  • Bug fix

Platforms tested on

  • MAUI WinUI

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files

williambohrmann3
williambohrmann3 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I broke this, thanks for fixing.

@duffh
Copy link
Collaborator Author

duffh commented Aug 11, 2023

I'm sorry I broke this, thanks for fixing.

No problem, easily done!

@duffh duffh merged commit f1bb440 into v.next Aug 11, 2023
2 checks passed
@duffh duffh deleted the hduff/fix-vnext-build branch August 11, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williambohrmann3 williambohrmann3 williambohrmann3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duffh @williambohrmann3