Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Geodatabase transactions sample when navigating away #1283

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

duffh
Copy link
Collaborator

@duffh duffh commented Aug 11, 2023

Description

A missing null check resulted in a thrown exception when navigating away from the Geodatabase transactions sample.

Type of change

  • Bug fix

Platforms tested on

  • WPF .NET 6
  • WPF Framework
  • WinUI

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files

Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! tested both sample implementations.

@williambohrmann3
Copy link
Collaborator

Quite rare, have only been able to repro this once after about 10 attempts:
getting these errors after changing samples then returning to GeodatabaseTransactions:
devenv_EZfguTkMOa
Might be worth looking into but I don't think this is related to your PR. Very odd I only could repro this once.

@duffh duffh merged commit d56c402 into v.next Aug 14, 2023
2 checks passed
@duffh duffh deleted the hduff/geodatabase-transaction-crash-fix branch August 14, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants