Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add flamegraph instructions for profiling #318

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented Jun 14, 2023

Description

Add cargo-flamegraph to nix-shell and add instructions to demonstrate how to run in in README.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@alxiong alxiong requested review from mrain and ggutoski June 14, 2023 16:57
@alxiong alxiong self-assigned this Jun 14, 2023
@alxiong alxiong mentioned this pull request Jun 14, 2023
4 tasks
@alxiong
Copy link
Contributor Author

alxiong commented Jun 14, 2023

Hold on merging perhaps, I might want to explore more other tools with different presentation on the profiled performance.

README.md Show resolved Hide resolved
@alxiong alxiong force-pushed the flamegraph branch 2 times, most recently from 5d9ab4b to 1620f33 Compare June 15, 2023 13:14
@alxiong alxiong force-pushed the flamegraph branch 2 times, most recently from f863992 to 4b4827d Compare June 15, 2023 14:45
@alxiong alxiong mentioned this pull request Mar 7, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants