This repository has been archived by the owner on Feb 5, 2025. It is now read-only.
[WEEKLY RELEASE] Bump HotShot #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinI
force-pushed
the
hotshot/0.5.82
branch
from
f695849 to
0268864
Compare
QuentinI
force-pushed
the
hotshot/0.5.82
branch
from
0268864 to
8695018
Compare
QuentinI
requested review from
sveitser,
jbearer and
imabdulbasit
as code owners
imabdulbasit
reviewed
Dec 5, 2024
Cargo.toml
Outdated
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| [package] | |||
| name = "hotshot-query-service" | |||
| version = "0.1.62" | |||
| version = "0.1.63" | |||
There was a problem hiding this comment.
we haven't updated this in a while. The version should be 0.1.75
imabdulbasit
reviewed
Dec 5, 2024
src/availability/query_data.rs
Outdated
| @@ -190,8 +190,8 @@ pub trait QueryablePayload<Types: NodeType>: traits::BlockPayload<Types> { | |||
| #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq)] | |||
| #[serde(bound = "")] | |||
| pub struct LeafQueryData<Types: NodeType> { | |||
| pub(crate) leaf: Leaf<Types>, | |||
| pub(crate) qc: QuorumCertificate<Types>, | |||
| pub(crate) leaf: Leaf2<Types>, | |||
There was a problem hiding this comment.
hmm I am not too sure about this change. We should be inserting Leaf1 for now or migrate the exisitng leaves to Leaf2 and start inserting leaf2
There was a problem hiding this comment.
but in the sequencer, we are inserting V1 of everything so I think we want to keep it as Leaf1?
imabdulbasit
approved these changes
Dec 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review: