Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of large responses in nasty client #2320

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve handling of large responses in nasty client #2320

wants to merge 2 commits into from

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented Nov 22, 2024

Some of the responses to queries like payload queries and range queries can be up to a few megabytes. This change prevents distracting spurious warnings and errors for such responses.

This PR:

  • increases the HTTP client timeout to allow plenty of time to stream the response over the network
  • only counts queries as slow if it takes longer than 1s to receive a response header -- the time it takes to stream the response does not count toward slow warnings, as this time is not taking computational resources on the server

@jbearer
Improve handling of large responses in nasty client
8774a41 
Some of the responses to queries like payload queries and range
queries can be up to a few megabytes. This change prevents distracting
spurious warnings and errors for such responses by
* increasing the HTTP client timeout to allow plenty of time to stream
  the response over the network
* only counting queries as slow if it takes longer than 1s to receive
  a response header -- the time it takes to stream the response does
  not count toward slow warnings, as this time is not taking
  computational resources on the server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@tbro tbro Awaiting requested review from tbro tbro is a code owner

@imabdulbasit imabdulbasit Awaiting requested review from imabdulbasit imabdulbasit is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jbearer