Add calculation of exact encoded transaction as a function in Transaction trait #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dailinsubjam
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
shenkeyao
reviewed
Oct 28, 2024
types/src/v0/impls/transaction.rs
Outdated
| @@ -60,6 +62,15 @@ impl Transaction { | |||
| self.payload | |||
| } | |||
|
|
|||
| pub fn size_in_block(&self, new_ns: bool) -> u64 { | |||
| if new_ns { | |||
| // each new namespace adds overhead, therefore it includes `NsTableBuilder::entry_byte_len() + NsPayloadBuilder::tx_table_header_byte_len()` | |||
There was a problem hiding this comment.
This comment makes it sound like we will add an overhead for new namespaces. Can we reword it to something like:
> Each new namespace already includes the overhead, so we don't add it again.
There was a problem hiding this comment.
It's true that we will add an overhead NsTableBuilder::entry_byte_len() + NsPayloadBuilder::tx_table_header_byte_len() for new namespaces. let me add more comments.
shenkeyao
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EspressoSystems/marketplace-builder-core#169
This PR:
Hotshot changes: Add a trait for calculation of exact encoded transaction HotShot#3800
Builder changes: Add exact calculation of encoded transaction size marketplace-builder-core#202
This PR does not:
Key places to review: