[CHORE] Update jellyfish #2397
Merged
[CHORE] Update jellyfish #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
requested review from
shenkeyao,
elliedavidson and
bfish713
as code owners
jbearer
requested review from
mrain,
ggutoski,
bfish713,
shenkeyao and
elliedavidson
and removed request for
bfish713,
shenkeyao and
elliedavidson
ggutoski
approved these changes
Jan 13, 2024
| else { | ||
| let Ok(signature) = TYPES::SignatureKey::sign( | ||
| &self.private_key, | ||
| vid_disperse.payload_commitment.as_ref().as_ref(), |
There was a problem hiding this comment.
as_ref().as_ref() yikes. wish that could be cleaner 😕
There was a problem hiding this comment.
Yeah this could be fixed Jellyfish side. Just add AsRef<[u8]> or Into<Vec<u8>> or something like that
There was a problem hiding this comment.
new issue EspressoSystems/jellyfish#471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.