Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MPRIS background blur for app icons #369

Merged
merged 6 commits into from
Apr 21, 2024
Merged

Add MPRIS background blur for app icons #369

merged 6 commits into from
Apr 21, 2024

Conversation

abmantis
Copy link
Contributor

@abmantis abmantis commented Jan 6, 2024 •
edited
Loading

No description provided.

@abmantis
Fix default mpris icon size
a21d46f 
The widget was was using the .ui size instead of the user config
size in the following situations:

- there was no media player app
- the media player app icon was used
- the audio-x-generic-symbolic icon was used

This fix sets the default size for the album art icon according to the
user's config.

set_from_gicon and set_from_icon_name receive a Gtk.IconSize enum value,
not an int, so we need to call set_pixel_size to set the proper size.
@abmantis
Add MPRIS background blur for app icons
89e8dcb
@ErikReider
Copy link
Owner

Request a review when the PR is ready :)

@abmantis abmantis marked this pull request as ready for review February 25, 2024 02:24
@ErikReider
Copy link
Owner

I'll wait for #370 before reviewing :)

ErikReider
ErikReider requested changes Mar 25, 2024
View reviewed changes
Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and sorry for the delay! Resolve the merge conflicts and potential linting issues and I'll merge :)

@abmantis
Copy link
Contributor Author

Thanks for the catch and sorry for the delay! Resolve the merge conflicts and potential linting issues and I'll merge :)

No problem :)
Running the linter made quite a lot of changes to the whole file :/ I hope that is ok.

@ErikReider
Copy link
Owner

Thanks for the catch and sorry for the delay! Resolve the merge conflicts and potential linting issues and I'll merge :)

No problem :)
Running the linter made quite a lot of changes to the whole file :/ I hope that is ok.

Oh yeah, the formatter is kinda broken... Can you restore back and just fix the lines that the linter is complaining about? One day I'll get to fixing this annoying formatter...

@abmantis
Copy link
Contributor Author

Thanks for the catch and sorry for the delay! Resolve the merge conflicts and potential linting issues and I'll merge :)

No problem :)
Running the linter made quite a lot of changes to the whole file :/ I hope that is ok.

Oh yeah, the formatter is kinda broken... Can you restore back and just fix the lines that the linter is complaining about? One day I'll get to fixing this annoying formatter...

It is a bit of a pain currently, because it also is not able to format just selected lines (it messes them up).

@abmantis abmantis requested a review from ErikReider March 28, 2024 23:56
@abmantis
Copy link
Contributor Author

@ErikReider can we merge this?

ErikReider
ErikReider approved these changes Apr 21, 2024
View reviewed changes
Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@ErikReider ErikReider merged commit af8ac2f into ErikReider:main Apr 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikReider ErikReider ErikReider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abmantis @ErikReider