Added new analyzer for strings and interpolated strings to identify and inspect sql #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vendettamit
commented
Sep 19, 2016
vendettamit
commented
- Added new analyzer method
- Fixed bug with token null reference exception in Run method
- Fixed spaces by Tabs
…statements in string variables.
…ckin. Fixed space with tabs.
|
Hi looks good - but I have 2 comments: 1: Could you please submit the PR to the https://github.com/DotNetAnalyzers/TSqlAnalyzer repo (this is just my fork, sorry about any confusion) 2: Could you submit you refactorings in a seperate PR, it is very hard to see what is new code in the Github diff |
|
Thanks ErikEj. I'll try to do it by today evening. |
|
Here's the pull request for original repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.