-
Notifications
You must be signed in to change notification settings - Fork 449
[feat] Add new report filtering mode #4712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add new report filtering mode #4712
Conversation
8632bcf to
4036a72
Compare
4036a72 to
dc51fa7
Compare
dkrupp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I have some minor remarks for the documentation and tests.
ab3facb to
5971012
Compare
dkrupp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this new option to the web user guide
https://github.com/Ericsson/codechecker/blob/master/docs/web/user_guide.md
dkrupp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rephrase the help text a bit.
...vue-cli/src/components/Report/ReportFilter/Filters/SelectOption/ReportFilterModeSelector.vue
Outdated
Show resolved
Hide resolved
...vue-cli/src/components/Report/ReportFilter/Filters/SelectOption/ReportFilterModeSelector.vue
Outdated
Show resolved
Hide resolved
...vue-cli/src/components/Report/ReportFilter/Filters/SelectOption/ReportFilterModeSelector.vue
Outdated
Show resolved
Hide resolved
|
Shouldn't this feature be introduced for "File" filter, too? That also has "anywhere on bug path" option. |
dkrupp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a495736 to
02e8f55
Compare
This PR adds the ability to filter the reports to those only which has the all the path points in the same component.