Skip to content

Conversation

@furtib
Copy link
Contributor

@furtib furtib commented Sep 23, 2025

Why:
When working on Bezel, we encounter a situation where the result files are placed into a read-only folder. By default, CodeChecker store creates a temporary directory for zipping the results before sending them to the server. This directory cannot be created in a read-only folder, causing CodeChecker to crash.

What:
This pull request adds an extra command-line argument, --temp_dir, to the CodeChecker store command, which specifies where temporary files should be created. When this argument is not set, it continues to use the previous implementation.

Fixes: #4601

@furtib furtib requested a review from Szelethus September 23, 2025 15:02
@furtib furtib self-assigned this Sep 23, 2025
@furtib furtib added the bazel 🧩 Directly or inderectly related to bazel support label Sep 23, 2025
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is breaking.

Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit.

@furtib furtib force-pushed the store_tmp_dir_loc branch 2 times, most recently from 5c31813 to 03030da Compare September 30, 2025 15:12
@furtib
Copy link
Contributor Author

furtib commented Oct 6, 2025

A flowchart for the selection of the temporary zipfile location:

Flowchart_tmp_dir_CC

Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot the click "submit review"

@furtib furtib force-pushed the store_tmp_dir_loc branch from c595333 to 333c7da Compare October 7, 2025 13:11
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reflecting on our conversation yesterday, I think the term "temp" is way too ambigous. How about we call the flag --zip_dir, the variable that handles it same etc?

@furtib
Copy link
Contributor Author

furtib commented Oct 8, 2025

Reflecting on our conversation yesterday, I think the term "temp" is way too ambigous. How about we call the flag --zip_dir, the variable that handles it same etc?

In my opinion, it would be more fitting to name it --zip_loc then.

@furtib furtib force-pushed the store_tmp_dir_loc branch from 1e05620 to 1659f9e Compare October 10, 2025 11:54
@furtib furtib added the usability 👍 Usability-related features label Nov 25, 2025
@bruntib bruntib added this to the release 6.27.0 milestone Dec 4, 2025
@furtib furtib requested a review from dkrupp as a code owner December 4, 2025 15:12
@furtib furtib requested a review from bruntib December 4, 2025 15:14
@bruntib bruntib merged commit 5d64100 into Ericsson:master Dec 4, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bazel 🧩 Directly or inderectly related to bazel support usability 👍 Usability-related features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-existent tmpfile while storing after analysis with bazel

3 participants