Skip to content

Conversation

@Kalfou
Copy link
Collaborator

@Kalfou Kalfou commented Nov 1, 2022

Logging to file option added.
In this version the java plugins log to their own files, while the C++ parts of the code log to a common file.

@intjftw intjftw linked an issue Nov 7, 2022 that may be closed by this pull request
@mcserep mcserep marked this pull request as ready for review November 14, 2022 16:13
@mcserep mcserep requested review from intjftw and mcserep November 14, 2022 16:15
Copy link
Collaborator

@intjftw intjftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the log appears to me like this:

2023-01-09 14:30:28.856078000 [INFO] [cppparser] parse started!
2023-01-09 14:30:28.856732000 [INFO] (2/2) Parsing /home/efekane/repos/tinyxml2/tinyxml2.cpp
2023-01-09 14:30:28.856742000 [INFO] (1/2) Parsing /home/efekane/repos/tinyxml2/xmltest.cpp
2023-01-09 14:30:29.051323000 [INFO] Indexer started! Mode: CREATE

I think the fraction of seconds should not appear, it's more annoying than useful. This also applies to saving to file.
The other issue is that the exact time stamp appears in the "core" CC log files, while it does not appear in the search plugins log files. Otherwise the logging works well for both the parser and the webserver.

@intjftw
Copy link
Collaborator

intjftw commented Jan 9, 2023

One other thing I forgot in the review: the readme and the help text in both the parser and the webserver should be complemented with usage guide for logging options.

Copy link
Collaborator

@mcserep mcserep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍
A couple of minor changes should be made before merging.

Copy link
Collaborator

@mcserep mcserep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the corrections!

@mcserep mcserep merged commit e565660 into Ericsson:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write log messages to file

3 participants