-
Notifications
You must be signed in to change notification settings - Fork 113
Log file #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log file #588
Conversation
intjftw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the log appears to me like this:
2023-01-09 14:30:28.856078000 [INFO] [cppparser] parse started!
2023-01-09 14:30:28.856732000 [INFO] (2/2) Parsing /home/efekane/repos/tinyxml2/tinyxml2.cpp
2023-01-09 14:30:28.856742000 [INFO] (1/2) Parsing /home/efekane/repos/tinyxml2/xmltest.cpp
2023-01-09 14:30:29.051323000 [INFO] Indexer started! Mode: CREATE
I think the fraction of seconds should not appear, it's more annoying than useful. This also applies to saving to file.
The other issue is that the exact time stamp appears in the "core" CC log files, while it does not appear in the search plugins log files. Otherwise the logging works well for both the parser and the webserver.
plugins/search/indexer/indexer-java/src/cc/search/indexer/app/Indexer.java
Outdated
Show resolved
Hide resolved
|
One other thing I forgot in the review: the readme and the help text in both the parser and the webserver should be complemented with usage guide for logging options. |
mcserep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 👍
A couple of minor changes should be made before merging.
plugins/search/common/src/cc/search/common/ipc/IPCProcessor.java
Outdated
Show resolved
Hide resolved
mcserep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the corrections!
Logging to file option added.
In this version the java plugins log to their own files, while the C++ parts of the code log to a common file.