Fix recursive caller nodes #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Great work finding the source of this issue!
No, it's not a feature, but a bug 😄 |
mcserep
added
Kind: Bug ⚠️
Plugin: C++
mcserep
approved these changes
Feb 11, 2023
Collaborator
mcserep
left a comment
mcserep
left a comment
There was a problem hiding this comment.
Looks good, I don't know why it wasn't reviewed until now 😕
Let's get this merged now, anyway! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #544, which was caused by the children of the child caller nodes being set incorrectly. Recursions in the tree are also avoided now.
There is one issue remaining that I need some feedback on. When the child caller nodes are created, the reference count after their name is appended to instead of replaced, which means reference counts keep piling up as we go deeper in the tree. See "Caller(4)(8)(1)" in this screenshot.
This is not intentional, is it? In that case I can fix it too.