Improve error handling of CppServiceHandler #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes segfault
intjftw
requested changes
Mar 7, 2022
Collaborator
intjftw
left a comment
intjftw
left a comment
There was a problem hiding this comment.
Please modify according to the C++ coding convention (space between if and parentheses, else goes to new line after bracket), otherwise it's fine.
intjftw
added
Kind: Bug ⚠️
Plugin: C++
whisperity
reviewed
Apr 5, 2022
andocz
changed the title
Collaborator
|
@whisperity, @intjftw: Is there any reason this is not merged yet? Seems like all requested changes have been made and it looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a segfault happens when opening "This calls" in the info tree. For example at
tinyxml2::XMLDocument::SetError.I fixed this by adding a check against the query matching nothing, like how it's already done with other queries in the code.
The query is empty if the AST node has no corresponding CPP entity. In TinyXML2's case this happens with
__va_list_tag::__va_list_tag(). I assume this is an anomaly, so I added a warning log message.I also updated an extremely outdated comment.