Filter C/C++ compile commands #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intjftw
added
Kind: Enhancement 🌟
Plugin: C++
bruntib
requested changes
Feb 16, 2022
plugins/cpp/parser/src/cppparser.cpp
Outdated
Comment on lines
755
to
756
| const std::vector<std::string> cppExts{ | ||
| ".c", ".cc", ".cpp", ".cxx", ".o", ".so", ".a"}; |
Collaborator
There was a problem hiding this comment.
There is a function already which checks whether a file is a cpp file:
https://github.com/Ericsson/CodeCompass/blob/master/plugins/cpp/parser/src/cppparser.cpp#L157-L166
plugins/cpp/parser/src/cppparser.cpp
Outdated
| const std::vector<std::string> cppExts{ | ||
| ".c", ".cc", ".cpp", ".cxx", ".o", ".so", ".a"}; | ||
|
|
||
| std::copy_if(tempCompileCommands.begin(), tempCompileCommands.end(), |
Collaborator
There was a problem hiding this comment.
We could remove elements with remove_if or something similar in order to avoid a copy of the compile commands.
bruntib
reviewed
Feb 16, 2022
plugins/cpp/parser/src/cppparser.cpp
Outdated
| ".c", ".cc", ".cpp", ".cxx", ".o", ".so", ".a"}; | ||
|
|
||
| std::copy_if(tempCompileCommands.begin(), tempCompileCommands.end(), | ||
| std::back_inserter(compileCommands), [&](clang::tooling::CompileCommand c) |
Collaborator
There was a problem hiding this comment.
Suggested change
| std::back_inserter(compileCommands), [&](clang::tooling::CompileCommand c) | |
| std::back_inserter(compileCommands), [&](const clang::tooling::CompileCommand& c) |
Collaborator
Author
|
Thanks @bruntib, I committed all changes you requested. |
bruntib
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter compile commands from
compile_commands.jsonso C++ plugin won't try to parse everything in case of a multi-language project.