-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle assistant messages with 'tool_calls' #824
base: master
Are you sure you want to change the base?
Conversation
Handle assistant messages with 'tool_calls' when used in chat_template
Code Metrics Report=============================================================================== Language Files Lines Code Comments Blanks =============================================================================== C Header 2 35 28 0 7 Dockerfile 1 34 25 0 9 Happy 1 442 369 0 73 JSON 12 105 104 0 1 Python 52 2280 1940 68 272 TOML 20 630 564 2 64 YAML 2 21 19 2 0 ------------------------------------------------------------------------------- Jupyter Notebooks 4 0 0 0 0 |- Markdown 2 77 32 31 14 |- Python 2 196 169 1 26 (Total) 273 201 32 40 ------------------------------------------------------------------------------- Markdown 38 2800 0 2129 671 |- BASH 6 103 100 0 3 |- JSON 1 12 12 0 0 |- Python 5 92 82 0 10 |- Rust 9 322 274 0 48 |- TOML 2 75 63 0 12 (Total) 3404 531 2129 744 ------------------------------------------------------------------------------- Rust 267 78791 70730 1671 6390 |- Markdown 131 1363 25 1243 95 (Total) 80154 70755 2914 6485 =============================================================================== Total 400 85138 73779 3872 7487 =============================================================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Jeadie! Thanks for the PR. I think this looks good, but I was wondering if you could also please update the new Rust API (specifically, the tools
and tools_llama_8b
examples)? Perhaps you could create a method to add a tool call message?
Please let me know!
Friendly ping @Jeadie |
Will do today |
Add better methods for using tools in and update examples
I don't seem to have visibility into the failing check: https://github.com/EricLBuehler/mistral.rs/actions/runs/11357273044/job/31589861979?pr=824 |
@Jeadie I reran the check and it passed. Please let me know when this is ready for review! |
This is ready to review |
Changes
BasicProcessor
to usetemplate_action() -> MessagesAction::Keep
(instead ofMessagesAction::FlattenOnlyText
) .Fixes