Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Gemma 2 model #84

Closed
wants to merge 8 commits into from
Closed

Add support for the Gemma 2 model #84

wants to merge 8 commits into from

Conversation

EricLBuehler
Copy link
Owner

Refs #79

@EricLBuehler
Copy link
Owner Author

@guoqingbao the model runs but seems to give garbage output. Do you see anything which stands out?

@guoqingbao
Copy link
Collaborator

@guoqingbao the model runs but seems to give garbage output. Do you see anything which stands out?

Perhaps there is a need for 'attn_logit_softcapping' if 'final_logit_softcapping' is used.

@guoqingbao
Copy link
Collaborator

I found the recent update #83 overwritten previous bug fixes including #80 @EricLBuehler

@guoqingbao
Copy link
Collaborator

@guoqingbao the model runs but seems to give garbage output. Do you see anything which stands out?

Perhaps there is a need for 'attn_logit_softcapping' if 'final_logit_softcapping' is used.

I have submitted a PR #86 to resolve the issue where both 'attn_logit_softcapping' and 'final_logit_softcapping' are necessary for gemma-2 inference. The corresponding PA kernel has also been revised. I'm curious why this isn't supported in vLLM. Google only mentioned that softcapping is beneficial for training.

@EricLBuehler
Copy link
Owner Author

@guoqingbao sounds good, I'll close this PR!

@EricLBuehler EricLBuehler deleted the gemma2 branch August 21, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants