Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving pre-commit to a dev dep. #384

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Moving pre-commit to a dev dep. #384

merged 1 commit into from
Dec 20, 2024

Conversation

mcottontensor
Copy link
Collaborator

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU
  • Other

Problem statement:

pre-commit was a normal dependency not a dev dependency.

Solution

Moves pre-commit to a dev dependency.

@mcottontensor mcottontensor merged commit ffeb52c into EpicGamesExt:master Dec 20, 2024
@mcottontensor mcottontensor deleted the pre-commit-updates branch December 20, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehb lukehb lukehb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcottontensor @lukehb