Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad id checks #383

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix bad id checks #383

merged 1 commit into from
Dec 20, 2024

Conversation

Belchy06
Copy link
Collaborator

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

Follow on from #380, some checks check for controller.id when they should really check controller.id !== undefined because 0 is a valid controller index.

Solution

Fix the checks

@mcottontensor mcottontensor added auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.5 labels Dec 20, 2024
@mcottontensor mcottontensor merged commit 13ce022 into EpicGamesExt:master Dec 20, 2024
5 checks passed
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
UE5.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mcottontensor added a commit that referenced this pull request Dec 20, 2024
[UE5.5] Merge pull request #383 from Belchy06/gamepad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants