Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one-arg method Duplicated(x) #2118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mcabbott
Copy link
Contributor

@mcabbott mcabbott commented Nov 23, 2024

Instead of writing

dx = make_zero(x)
xdx = Duplicated(x, dx)

this lets you write

xdx = Duplicated(x)

and later get dx = xdx.dval out when you need it.

Should there also be DuplicatedNoNeed(x), and perhaps BatchDuplicated(x, n::Int)?

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.22%. Comparing base (037dfed) to head (9e26b67).
Report is 238 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2118      +/-   ##
==========================================
+ Coverage   67.50%   70.22%   +2.71%     
==========================================
  Files          31       42      +11     
  Lines       12668    15784    +3116     
==========================================
+ Hits         8552    11084    +2532     
- Misses       4116     4700     +584     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants