Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_zero(!) bugfixes and improved tests #1961

Merged
merged 6 commits into from
Nov 28, 2024
Merged

Conversation

danielwe
Copy link
Contributor

Since #1852 isn't quite ready, in the meantime, here's a PR fixing the bugs I found in make_zero(!) and adding a fairly thorough test suite.

The last test currently fails due to #1935. I didn't want to mark it as broken because I'd rather see #1936 merged (or #1935 fixed in some other way), but let me know if I should change that.

@danielwe danielwe changed the title Fix make zero Stopgap make_zero bugfix Oct 11, 2024
src/make_zero.jl Outdated Show resolved Hide resolved
@danielwe
Copy link
Contributor Author

Thanks for taking a look! I noticed a few other issues that should be fixed too. However, #1852 is almost there (I've been in a cycle of thorough tests => noticing issues => fixing/improving design accordingly => repeat), so if you don't mind I'll finish the big push on that, and then we can decide whether it's worth fixing and merging this one first (say, if reviewing #1852 is too big of a task to deal with right now), or if we should close this one and focus on #1852

@danielwe danielwe marked this pull request as draft October 24, 2024 02:55
@vchuravy
Copy link
Member

Can you rebase this? I think I would like to get this merged first before dealing with the much larger change in #1852

@danielwe
Copy link
Contributor Author

Sure! Just give me a minute to incorporate some additional fixes and improvements I've made in the meantime

@danielwe danielwe marked this pull request as ready for review November 27, 2024 18:51
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.11888% with 27 lines in your changes missing coverage. Please review.

Project coverage is 70.64%. Comparing base (037dfed) to head (636b025).
Report is 244 commits behind head on main.

Files with missing lines Patch % Lines
src/make_zero.jl 77.68% 27 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1961      +/-   ##
==========================================
+ Coverage   67.50%   70.64%   +3.14%     
==========================================
  Files          31       44      +13     
  Lines       12668    16122    +3454     
==========================================
+ Hits         8552    11390    +2838     
- Misses       4116     4732     +616     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielwe danielwe changed the title Stopgap make_zero bugfix make_zero(!) bugfixes and improved tests Nov 27, 2024
Aiming for full coverage of both new and old implementations of
make_zero(!)
src/make_zero.jl Outdated Show resolved Hide resolved
@wsmoses wsmoses merged commit 45f01bd into EnzymeAD:main Nov 28, 2024
18 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants