Delinearize indexing #318
Merged
Delinearize indexing #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Feb 7, 2025
test/lit_tests/raising/multidim.mlir
Outdated
| // CHECK-SAME: %[[VAL_0:[^:]*]]: memref<?x5x3xi64, 1>) { | ||
| // CHECK: %[[VAL_1:.*]] = arith.constant 1 : i64 | ||
| // CHECK: affine.parallel (%[[VAL_2:.*]], %[[VAL_3:.*]], %[[VAL_4:.*]]) = (0, 0, 0) to (7, 5, 3) { | ||
| // CHECK: affine.store %[[VAL_1]], %[[VAL_0]]{{\[}}%[[VAL_2]] + (%[[VAL_3]] + %[[VAL_4]] floordiv 3) floordiv 5, (%[[VAL_3]] + %[[VAL_4]] floordiv 3) mod 5, %[[VAL_4]] mod 3] : memref<?x5x3xi64, 1> |
There was a problem hiding this comment.
the outer one should get simplified to floordiv 15, right?
There was a problem hiding this comment.
we also ideally want to be able to remove val4 floordiv3 -> 0 [since its always less than 3]
ivanradanov
force-pushed
the
delinearize
branch
from
1048d8e to
37685a9
Compare
ivanradanov
commented
Feb 12, 2025
| // CHECK-SAME: %[[VAL_0:[^:]*]]: memref<?x5x3xi64, 1>) { | ||
| // CHECK: %[[VAL_1:.*]] = arith.constant 1 : i64 | ||
| // CHECK: affine.parallel (%[[VAL_2:.*]], %[[VAL_3:.*]], %[[VAL_4:.*]]) = (0, 0, 0) to (7, 5, 3) { | ||
| // CHECK: affine.store %[[VAL_1]], %[[VAL_0]]{{\[}}%[[VAL_2]], %[[VAL_3]], %[[VAL_4]]] : memref<?x5x3xi64, 1> |
There was a problem hiding this comment.
@wsmoses Now we manage to eliminate all floordiv and mod.
ivanradanov
commented
Feb 12, 2025
|
I think I fixed the crash and it should be good now |
wsmoses
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.