Transform llvm.ptr arg to memref arg #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we had a bit of a race condition whree @ivanradanov also added this functionality in https://github.com/EnzymeAD/Enzyme-JAX/pull/303/files#diff-226e98da706121c678606489ff574cfe82f6143f1cfeb844c99d4d7dc2a94deb That said a separate pass is nicer for debugging, so let's go with this. A quick review: |
wsmoses
reviewed
Feb 6, 2025
wsmoses
reviewed
Feb 6, 2025
wsmoses
reviewed
Feb 6, 2025
wsmoses
reviewed
Feb 6, 2025
wsmoses
reviewed
Feb 10, 2025
wsmoses
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
lgtm modulo the jitcall fix
@ivanradanov can you also give this a once over?
|
Updated with jit call fix |
wsmoses
reviewed
Feb 11, 2025
| DenseMap<FunctionOpInterface, SetVector<CallOpInterface>> funcToKernelMap; | ||
| moduleOp->walk([&](CallOpInterface callOp) { | ||
| auto symbolName = | ||
| dyn_cast_or_null<SymbolRefAttr>(callOp.getCallableForCallee()); |
There was a problem hiding this comment.
this shouldn't be any call interface, but just jit_call and kernel_call. We can still store as callopinterface, but we should only walk the Jit and kernel call ops
wsmoses
reviewed
Feb 11, 2025
wsmoses
reviewed
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.