Add mock implementations for Obsidian API and tests #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for GitHub REST API functions using mock Obsidian API. * **Mock Obsidian API**: Create `src/__mocks__/obsidian.ts` to mock `app.vault`, `app.metadataCache`, and `app.workspace` methods. * **Branch Tests**: Add `src/GitHub/branch.test.ts` to test `GithubBranch` class methods `newBranch`, `pullRequestOnRepo`, and `deleteBranchOnRepo`. * **Delete Tests**: Add `src/GitHub/delete.test.ts` to test `deleteFromGithub` and `filterGithubFile` functions. * **Files Tests**: Add `src/GitHub/files.test.ts` to test `FilesManagement` class methods `getSharedFiles`, `getAllFileWithPath`, and `getLinkedByEmbedding`. * **Upload Tests**: Add `src/GitHub/upload.test.ts` to test `Publisher` class methods `publish`, `uploadOnMultipleRepo`, and `uploadImage`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Enveloppe/obsidian-enveloppe?shareId=XXXX-XXXX-XXXX-XXXX).
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/GitHub/delete.test.ts:91
- The test should include some filtering logic to ensure the function works as expected.
const result = await filterGithubFile(fileInRepo, settings, prop);
| new TFile('file2.md', 'file2.md', 0, 0, 0, 0, 0, 0, 0, 0, 0), | ||
| ]; | ||
|
|
||
| app.vault.getFiles.mockReturnValue(files); |
There was a problem hiding this comment.
The method getFiles does not exist on the mock app.vault object. It should be getMarkdownFiles.
Suggested change
| app.vault.getFiles.mockReturnValue(files); | |
| app.vault.getMarkdownFiles.mockReturnValue(files); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for GitHub REST API functions using mock Obsidian API.
src/__mocks__/obsidian.tsto mockapp.vault,app.metadataCache, andapp.workspacemethods.src/GitHub/branch.test.tsto testGithubBranchclass methodsnewBranch,pullRequestOnRepo, anddeleteBranchOnRepo.src/GitHub/delete.test.tsto testdeleteFromGithubandfilterGithubFilefunctions.src/GitHub/files.test.tsto testFilesManagementclass methodsgetSharedFiles,getAllFileWithPath, andgetLinkedByEmbedding.src/GitHub/upload.test.tsto testPublisherclass methodspublish,uploadOnMultipleRepo, anduploadImage.For more details, open the Copilot Workspace session.