Docker: Raise error if VEP version and release branch mismatch #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likhitha-surapaneni
approved these changes
Sep 2, 2024
likhitha-surapaneni
merged commit 1959ffd
into
Ensembl:postreleasefix/113
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the branch name to build the Docker image starts with
release/(release branch), raise an error if there is a mismatch between VEP version and the version in the release branch name.Testing
Check Docker image build completes depending on the branch argument:
ARG BRANCH=main, it should build successfullyARG BRANCH=release/113, it should pass (depending on the VEP version in modules/Bio/EnsEMBL/VEP/Constants.pm)ARG BRANCH=release/113.4, it should pass (subversions are ignored)ARG BRANCH=release/112, it should fail