Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding to the stats #1560

Open
wants to merge 1 commit into
base: release/112
Choose a base branch
from
Open

adding to the stats #1560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/Bio/EnsEMBL/VEP/Stats.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,7 @@ sub generate_run_stats {
my @return = (
['Species', $self->species],
['Command line options', '<pre>'.join(" ", @opts).'</pre>'],
['Full command line options', '<pre>'.$self->config->{_params}->{full_command}.'</pre>'],
Comment on lines 647 to +648
Copy link
Contributor

@nuno-agostinho nuno-agostinho Jan 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dbolser,

Thanks for your PR.

It depends on our internal release schedule, but usually any PR should be merged into the latest postreleasefix branch.

Regarding your changes, I think it would be better to simply replace the functionality of Command line options, so we return the same string as in the VCF output. What do you think?

Suggested change
['Command line options', '<pre>'.join(" ", @opts).'</pre>'],
['Full command line options', '<pre>'.$self->config->{_params}->{full_command}.'</pre>'],
['Command line options', '<pre>'.$self->config->{_params}->{full_command}.'</pre>'],

Let me know if you have any other questions. Thanks!

Best regards,
Nuno

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dbolser, are you fine with me making the change that I suggested? Let me know, thanks!

['Start time', $self->start_time],
['End time', $self->end_time],
['Run time', $self->run_time." seconds"],
Expand Down