added gRPC reflection to Thoas client #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilalebi
requested changes
Nov 18, 2024
There was a problem hiding this comment.
You'll want to revert these changes that I've added a while ago as well, since we won;t be able to get the tag from requirements.txt anymore 😢
bilalebi
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server reflection allows gRPC clients to dynamically query information about a gRPC server's services, methods, and message types, making it easier to explore and use services.
This PR implements gRPC reflection for the Thoas client making it no longer dependent on the ensembl-metadata-api (gRPC server).
However the "Genome" model from ensembl-metadata-api is still used by some resolver functions in Thoas so the package is still left alone in this project.