Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some of Pylint warnings for CI CD to pass #137

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Fix some of Pylint warnings for CI CD to pass #137

merged 4 commits into from
Feb 15, 2024

Conversation

bilalebi
Copy link
Contributor

@bilalebi bilalebi commented Jan 30, 2024 •
edited
Loading

CI CD was failing here because pylint test was below the threshold (9.5/10)

Changes

  • Fix Pylint and Black
  • Fix Github actions and add pylint to the workflow
  • Run GitHub actions on multiple python versions (3.8 and 3.9) for compatibility check

@bilalebi bilalebi marked this pull request as ready for review January 30, 2024 13:12
@bilalebi bilalebi requested a review from sanjay-boddu January 30, 2024 13:12
@bilalebi bilalebi self-assigned this Jan 31, 2024
@bilalebi bilalebi merged commit c40ae3d into develop Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjay-boddu sanjay-boddu sanjay-boddu approved these changes

Assignees

@bilalebi bilalebi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilalebi @sanjay-boddu