Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SpliceAI.pm #721

Closed
wants to merge 1 commit into from
Closed

Update SpliceAI.pm #721

wants to merge 1 commit into from

Conversation

SouzaBB
Copy link

@SouzaBB SouzaBB commented Jun 5, 2024

Formated tab output for Ensembl VEP

Formated tab output for Ensembl VEP
@dglemos dglemos self-requested a review June 13, 2024 15:34
@dglemos dglemos self-assigned this Jun 13, 2024
@dglemos
Copy link
Contributor

dglemos commented Jun 13, 2024

Hi @SouzaBB,
Is there a specific use case you need to have the different scores separated in the default VEP format?
In the VCF output format the scores are separated.

Changing the output format implies we also have to change the description here and the headers here.

@SouzaBB
Copy link
Author

SouzaBB commented Jun 14, 2024

So, yes.. It makes it easier to see the results in the tab output format. Getting everything into the same cell without a proper header implies that one could interpret the wrong results if looking into the wrong value.
Also, if you want to use those values in any downstream analysis it's also easier rather than formating a vcf output file or parsing data from it.

@dglemos
Copy link
Contributor

dglemos commented Jun 27, 2024

Updating the output format makes sense however, changing it by default could impact pipelines running the plugin.

To avoid any problesm, the output format could be updated as an option that way jobs using the plugin would not be impacted.
Could you please update your code to optionally change the output format.

In method new() check new option:

if(defined($param_hash->{split_output})) {
  $self->{split_output} = 1;
}

Update get_header_info()

if($output_vcf || $self->{split_output}) {
  (...)
}

Update run()

if($output_vcf || $self->{config}->{output_format} eq "json" || $self->{config}->{rest} || $self->{split_output})  {
  (...)
}

Finally update the description to reflect the new option.

@dglemos
Copy link
Contributor

dglemos commented Jun 27, 2024

The changes should be made against main branch.

Thanks!

@dglemos
Copy link
Contributor

dglemos commented Sep 3, 2024

Hi @SouzaBB,
Can you please update this branch against main?

@dglemos
Copy link
Contributor

dglemos commented Dec 6, 2024

I'm closing this PR - these updates are included in the following PR #756

@dglemos dglemos closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants