-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to modify gpio base path for testing purposes #40
base: master
Are you sure you want to change the base?
Conversation
Maybe you'll be interested in: |
Please rebase and send cleanup patches separately. |
d09a3f3
to
a114ce2
Compare
@rzr there you go :) |
Thx, |
From a software design perspective, I think it makes more sense to set the base directory path on the class method. On an instance level, the test option should be the filename which contains the value rather than the directory. Also this is probably unintentional but the entire package.json file is overridden which may cause reference problems when it's publish in npm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep the var vs const and fix conflict then I think it can be mergeable
lib/gpio.js
Outdated
|
||
var logError = function (e) { | ||
function logError(e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is fine,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please split this PR in several PR with smaller changes
"name": "gpio", | ||
"version": "0.4.0", | ||
"author": { | ||
"name": "Sebastian Alkemade", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to change author ? here
Please try to split this change is smaller PR |
Is there any interest to upstream this for next release ? |
Maybe you can try to demonstrate this by controlling on board leds : ie emulate actions in: would be forwarded to: does it make sense ? |
No description provided.