Skip to content

Conversation

octylFractal
Copy link
Member

@octylFractal octylFractal commented Sep 7, 2024

Fixes #2516

TODO:

  • Config opt
  • Clean up code
  • NeoForge
  • Paper (augh reflection)

@octylFractal octylFractal added the type:performance Performance-related issue label Sep 7, 2024
@octylFractal octylFractal added this to the 7.3.7 milestone Sep 7, 2024
@octylFractal octylFractal self-assigned this Sep 7, 2024
@octylFractal octylFractal changed the base branch from version/7.3.x to master September 12, 2024 02:19
@octylFractal octylFractal force-pushed the ot/featurefix/oooooo-you-like-editing-chunks-ur-a-chunk-section-editor branch from 3f1652b to deb26cb Compare September 12, 2024 02:19
@octylFractal octylFractal marked this pull request as ready for review September 12, 2024 02:19
@octylFractal octylFractal requested a review from a team as a code owner September 12, 2024 02:19
@octylFractal octylFractal modified the milestones: 7.3.7, 7.4.0 Sep 12, 2024
@octylFractal
Copy link
Member Author

@avaruus1 if you're interested in keeping the Sponge part up-to-date with everything, there are changes here that need to be made. As we don't want to maintain it, I just removed the broken code. This won't land for at least a couple months so there's plenty of time to adjust.

@avaruus1
Copy link
Contributor

avaruus1 commented Oct 3, 2024

@avaruus1 if you're interested in keeping the Sponge part up-to-date with everything, there are changes here that need to be made. As we don't want to maintain it, I just removed the broken code. This won't land for at least a couple months so there's plenty of time to adjust.

I think the side effect calculation is fine to remove as is. The block change flags are set already here. Is there some other scenarios where this is possibly used?

@octylFractal
Copy link
Member Author

No, it's only useful if the platform calls out to it. If you don't want to port the chunk section stuff then there should be nothing to do.

@octylFractal octylFractal force-pushed the ot/featurefix/oooooo-you-like-editing-chunks-ur-a-chunk-section-editor branch 2 times, most recently from 094750c to 00a4050 Compare March 9, 2025 08:23
@octylFractal octylFractal force-pushed the ot/featurefix/oooooo-you-like-editing-chunks-ur-a-chunk-section-editor branch from 00a4050 to 6648b87 Compare March 9, 2025 08:23
@octylFractal
Copy link
Member Author

I have tested this as much as I could, but it's still possible some edge case isn't being handled. Otherwise, this should be good to merge.

@octylFractal octylFractal requested a review from me4502 March 9, 2025 19:27
@Wueffi
Copy link

Wueffi commented Jun 10, 2025

Is this dead?

@octylFractal
Copy link
Member Author

Not really, but I haven't had energy to work on it.

@LordChrom
Copy link

can we label this as type:bug since it's the fix for #2516 ? 2516 renders the mod unusable for redstone, and I feel like the labels here should reflect that

@octylFractal
Copy link
Member Author

I'm not sure how adding that or not changes anything. It's not like we're going to merge it in to a patch version because it's now a "bug fix", it's way too drastic of a change for that.

@me4502 me4502 modified the milestones: 7.4.0, 8.0.0 Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:performance Performance-related issue
Development

Successfully merging this pull request may close these issues.

5 participants