-
-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clearblocks.js CraftScript #1370
Open
JsKingBoo
wants to merge
3
commits into
EngineHub:master
Choose a base branch
from
JsKingBoo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JsKingBoo
changed the title
Add clearblocks.py CraftScript
Add clearblocks.js CraftScript
Jun 22, 2020
MCEdit filter roots run deep fixed ty |
octylFractal
requested changes
Jun 23, 2020
smh my head fixed comment |
octylFractal
added
the
status:accepted
Will be fixed / added to WorldEdit, eventually
label
Aug 8, 2020
me4502
approved these changes
Jan 25, 2021
octylFractal
requested changes
Feb 11, 2021
var height = region.getHeight() | ||
var length = region.getLength() | ||
|
||
function sidesExposed(block) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire function can be replaced by the #surface
mask, don't recall the exact implementing class but it should be sufficient. I would rather not add more clunky code for us to maintain in the craftscripts dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status:accepted
Will be fixed / added to WorldEdit, eventually
type:feature-request
Request for something new
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contents of this CraftScript is less concerned about being useful and more focused on demonstrating the CraftScript API for aspiring developers. Thus the code performs an operation that is short and easy to understand.