Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using the //paste or //stack command, the redstone is inserted incorrectly. #2516

Open
5 tasks done
Xakerors opened this issue Apr 23, 2024 · 6 comments
Open
5 tasks done
Labels
status:accepted Will be fixed / added to WorldEdit, eventually type:bug Incorrect behavior, not working as intended

Comments

@Xakerors
Copy link

WorldEdit Version

7.3.0

Platform Version

Fabric 0.15.10

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEdit compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.
  • I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
  • I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)

Bug Description

Structures with the addition of redstone components are not fully inserted when trying to copy and paste them, or stack
2024-04-24_00 44 01
2024-04-24_00 44 47
2024-04-24_00 44 56
2024-04-24_00 45 18
them.

Expected Behavior

I expected that the structure would be fully installed with the preservation of redstone.

Reproduction Steps

  1. I select an area (two points)
  2. I choose the direction in order to execute the command "//stack"
  3. I'm writing "//stack"
  4. All the blocks were installed as needed, except for redstone.

Anything Else?

I want to say a very important point. If the selection area is affected only by the redstone and nothing superfluous, then it is inserted normally.
2024-04-24_00 58 27
2024-04-24_00 58 44
2024-04-24_00 58 48

@Xakerors Xakerors added status:pending Pending acceptance or closure. type:bug Incorrect behavior, not working as intended labels Apr 23, 2024
@octylFractal
Copy link
Member

Something changed in how redstone is updated, and we need to add an additional hook to prevent block breaking during it. We may shift how block placement is done entirely to avoid surprises like this, which would take longer.

@octylFractal octylFractal added status:accepted Will be fixed / added to WorldEdit, eventually and removed status:pending Pending acceptance or closure. labels Apr 24, 2024
@octylFractal
Copy link
Member

For others finding this issue, this does affect all platforms, as we use the same code to place on all of them.

@octylFractal octylFractal pinned this issue May 14, 2024
@zombachu
Copy link

zombachu commented May 19, 2024

Btw for those looking for a workaround, 7.2 doesn't have this problem if you're able to use it (tested on Paper 1.20.4)

@LordChrom
Copy link

LordChrom commented Nov 1, 2024

For those on a later MC version (1.20.5-1.21.1) you can get stuff to work very well if you

  • use worldedit 7.3.6
  • do "//reorder multi"

Some notes:

  • At the time of writing this, 7.3.7 and 7.3.8 are out, but this //reorder multi does not fix the issue in those versions.
  • I was using fabric for the testing.
  • I had no issues with //stack or //paste, but did have issues using //move, //cut, and //redo, but since such issue reports have been marked as duplicates of this this, I'm considering it to be enough the same bug that this is the right place to put all of this.
  • I'm fairly certain the issue is due to the way cutting (and similar operations) work because:
    • Items that pop off always do so at the source rather than at the destination (with moves and cuts)
    • Cutting with reorder multi and pasting with reorder fast/or none works fine
    • Cutting with reorder fast/none and pasting with multi is still bugged
    • Doing //copy then //set 0 works as expected in situations where //cut is bugged
    • All of this applies to 7.3.6

@LordChrom
Copy link

LordChrom commented Nov 2, 2024

In more recent versions (including building the code from the latest source) I do have occasional issues with pasting which are not present in 7.3.6 regardless of reorder mode.

Anyways I would greatly appreciate this being fixed as the mod is 80% less useful to me when I can't trust it with redstone. Lots of people I know are stuck using 7.2 for this reason, and the fact that there's no workaround in the latest version (other than replacing //cut, //paste with //copy, //set 0, //paste, //paste -a, spam //paste -a several more times if it's a complicated build, double check everything to make absolutely sure, )

@LordChrom
Copy link

as a hotfix for personal use I'm making a new reorder mode that does batchingExtent.setEnabled(false);
Here's my commit.
I won't do a pull request unless you ask, since I don't know what kinds of changes are wanted here, but I think something like this would be a good idea to implement just have a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted Will be fixed / added to WorldEdit, eventually type:bug Incorrect behavior, not working as intended
Projects
None yet
Development

No branches or pull requests

4 participants