feat(notifications): Add remote notifications (DO NOT MERGE) #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/yoroi into feat/remote-notifications
michaeljscript
commented
Dec 20, 2024
| "react-native-pager-view": "^6.2.0", | ||
| "react-native-paper": "4.12.8", | ||
| "react-native-permissions": "^3.8.0", | ||
| "react-native-permissions": "^5.2.1", |
There was a problem hiding this comment.
Updated to latest version
michaeljscript
commented
Dec 20, 2024
| @@ -316,5 +319,14 @@ | |||
| "compilerOptions": { | |||
| "module": "commonjs" | |||
| } | |||
| } | |||
| }, | |||
| "reactNativePermissionsIOS": [ | |||
There was a problem hiding this comment.
This is not specified in Podfile anymore
michaeljscript
commented
Dec 20, 2024
Comment on lines
+31
to
+33
| filePath = [[NSBundle mainBundle] pathForResource:@"GoogleService-Info-Nightly" ofType:@"plist"]; | ||
| } else { | ||
| filePath = [[NSBundle mainBundle] pathForResource:@"GoogleService-Info-Production" ofType:@"plist"]; |
There was a problem hiding this comment.
Notifications on iOS may need to be tested on nightly as iOS notifications don't work in dev mode
michaeljscript
commented
Dec 20, 2024
| const unsubscribeFromForegroundMessage = messaging().onMessage((remoteMessage) => { | ||
| const {notification} = remoteMessage | ||
| if (notification && notification.title && notification.body) { | ||
| sendNotification({ |
There was a problem hiding this comment.
This will be refactored / changed in the UI task, as local notifications are just a toast messages instead of real notifications.
|
@stackchain this PR is pretty much ready, but let's leave the PR there until we release 5.2.0 to avoid any merge conflicts or unnecessary reverts |
michaeljscript
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Change(s) / Related issue(s)
Add Android and iOS push notifications
TODO
Ticket
YV-119