Network switch API & UI #3762
Open
Network switch API & UI #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yushih
force-pushed
the
wallet-switch
branch
from
02e4e7b to
5ecb941
Compare
SorinC6
reviewed
Jan 10, 2025
There was a problem hiding this comment.
@yushih there are 2 things that I noticed on the UI:
- can you check the dark theme impl in the dialog as well, it seems like the text color is not correct
- when switching networks all the app page is refreshing - is this intentional?
- I see that some of the components were done using Class components, maybe in the next iteration, or if we have time, we can change and use functional ones when building new UI parts from now on
# Conflicts: # packages/yoroi-extension/app/api/localStorage/index.js # packages/yoroi-extension/app/i18n/locales/en-US.json
yushih
force-pushed
the
wallet-switch
branch
from
025f18c to
c8065f3
Compare
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backward-compatible change.
Jira task: https://emurgo.atlassian.net/browse/YOEXT-1385