Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed suggestions when providing generic type of self as the first parameter #529

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChrisUMB
Copy link

@ChrisUMB ChrisUMB commented Mar 21, 2023

Previously, there was an issue where if you provided a generic to a type, it would not properly suggest functions.

As you can see, if there is no generic, it properly suggests the function.
image

However, if there is a generic, it doesn't properly suggest the function.
image

This commit fixes that.
image

Furthermore, there was an issue where if you provided a generic type to the first parameter of a non-self function, it would not suggest it. It would suggest it if it wasn't a generic.
image

This commit also fixes that.

image

Note: I modified the gradle build file because it wouldn't properly build on my setup for some reason.

@alek13
Copy link

alek13 commented Jul 26, 2024

@ChrisUMB , is this the same problem?:

With @generic
image

Without @generic no error:
image

@alek13
Copy link

alek13 commented Jul 26, 2024

@ChrisUMB , anyway, can you rebase and solve conflicts, please ?

@CppCXY
Copy link
Member

CppCXY commented Jul 29, 2024

R%8I9}O`ULE5{ %RCY 7QG8
You can use VSCode to get more powerful generic support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants