-
Notifications
You must be signed in to change notification settings - Fork 110
Initial corrosion integration #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jake-Shadle
wants to merge
12
commits into
main
Choose a base branch
from
corro-dc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
There are a bunch of errors since none of the corrosion crates have license information so I'll fix that later since we're still on a fork. |
Member
Author
|
As well as the windows specific error due, again, to corrosion stuff. |
glindstedt
reviewed
Jan 29, 2026
glindstedt
reviewed
Jan 29, 2026
glindstedt
reviewed
Jan 29, 2026
glindstedt
reviewed
Jan 29, 2026
Closed
Member
Author
|
Note de7a1fc changed CI so that we can funnel jobs to a single consistent job for the branch check but add or remove tests in branches without needing to fiddle with the branch protection rules. |
glindstedt
approved these changes
Jan 30, 2026
Merged
Jake-Shadle
added a commit
that referenced
this pull request
Feb 5, 2026
This extracts the addition of the `test_success` job added in #1348 so that CI can pass successfully without that being merged. Having this single job that depends on other jobs to pass means we can add and remove jobs easily in PRs without needing to sync the branch protection rules for main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has an initial integration of the corrosion functionality into quilkin:
uidprovided by k8s instead of the endpoint address or k8snameClusterMap::corrosion_applywhich puts any clustermap changes received via a corrosion subscription into a specialcorrosionlocality. This is a temporary change just to not move around/refactor even more code in this PR, we should discuss what we want to do with ClusterMap (see theServerstype for what a refactor of the concept of aClusterMapmight be)filteranddatacenterchanges to a proxy config if it is configured