Set fifo rate and mpu addr #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the only failures I'm seeing are all related to the example I pushed in the last PR and that's because that code is specifically written for the LGT8F328p. What am I not seeing specifically? |
|
oops sorry I see the errors now. I'll look into it. |
|
No worries, we will be waiting for the changes. |
|
I was too hasty. Still not right even though checks passed. Don't merge yet. |
|
OK I think this PR is good now. Let me know if you see any other problems. |
sabas1080
approved these changes
Dec 13, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 small changes to
dmpInitialize():dmpInitialize()would set the FIFO rate at 100hz (hardcoded). This commit adds an optional parameter to set the FIFO rate and defaults to 100hz if no parameter is given. Rate is calculated by(200/(1+x))wherexis the optional parameter and defaults to1.dmpInitialize()assumes the MPU6050 address is 0x68 (hardcoded). This commit adds an optional parameter to set the address and defaults to address 0x68 if no address is given.slowing down the FIFO rate was my workaround to address issue #16. Theis commit maintains backward compatibility.