Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reverse connectivity #5

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

Edgar-21
Copy link
Owner

Previously the list of corners was simply reverse to change the handedness of the tris. This resulted in in a mismatch between the orientation of the triangles in the innermost surface and the subsequent surface, due to the need to have the normals point toward in the implicit complement.

@Edgar-21 Edgar-21 merged commit f9100d1 into pydagmc_model_generation Jan 23, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant