Integrate model merging #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples/pydagmc_example.py
Outdated
Comment on lines
5
to
6
| ribs = 150 | ||
| rib_pts = 160 |
There was a problem hiding this comment.
I'm assuming this is what was needed to make it smooth?
Examples/pydagmc_example.py
Outdated
Comment on lines
22
to
51
| radial_build_dict = { | ||
| "first_wall": { | ||
| "thickness_matrix": ones * 5, | ||
| "mat_tag": "iron", | ||
| }, | ||
| "breeder": { | ||
| "thickness_matrix": challenge_thickness_matrix, | ||
| "mat_tag": "iron", | ||
| }, | ||
| "back_wall": { | ||
| "thickness_matrix": ones * 0.01, | ||
| "mat_tag": "iron", | ||
| }, | ||
| "shield": { | ||
| "thickness_matrix": ones * 50, | ||
| "mat_tag": "iron", | ||
| }, | ||
| "vacuum_vessel": { | ||
| "thickness_matrix": ones * 10, | ||
| "mat_tag": "tungsten", | ||
| }, | ||
| "test_1": { | ||
| "thickness_matrix": ones * 0.1, | ||
| "mat_tag": "tungsten", | ||
| }, | ||
| "test_": { | ||
| "thickness_matrix": ones * 5, | ||
| "mat_tag": "tungsten", | ||
| }, | ||
| } |
There was a problem hiding this comment.
Maybe we should try and keep the radial build more inline with the parastell_example.py file. The name of the layer probably shouldn't be test_.
Examples/pydagmc_example.py
Outdated
Comment on lines
59
to
60
| num_ribs=ribs * 3, | ||
| num_rib_pts=rib_pts * 3, |
There was a problem hiding this comment.
Better to not increase rib number this way.
| import numpy as np | ||
| import parastell.parastell as ps | ||
| from parastell.utils import merge_dagmc_files | ||
|
|
There was a problem hiding this comment.
Maybe add back in the labels from parastell_example.py
Edgar-21
force-pushed
the
integrate_model_merging
branch
from
f6ecb3e to
20f5a1a
Compare
|
by my royal(?) decree, this is good eneough and shall be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a short script demonstrating making the ivb with pydagmc and the coils with cubit, then merging the two dagmc models. Updated the merge function to take a list of models.