-
-
Notifications
You must be signed in to change notification settings - Fork 336
Prettier husky #415
base: main
Are you sure you want to change the base?
Prettier husky #415
Conversation
Hello @eddiejaoude :) Can you please merge this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Please exclude CHANGELOG.md
file as this is autogenerated and will cause conflicts
Do you mean "review this PR"? BTW the extra notifications are not required @Cahllagerfeld are you able to review? |
Sorry for the notification |
thank you for understanding 👍 |
It should be excluded because of the prettier ignore. |
Oh strange, there are changes to the file https://github.com/EddieHubCommunity/good-first-issue-finder/pull/415/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed |
Strange why the ignore file is not being used, here are the official docs and the filename is correct https://prettier.io/docs/en/ignore.html |
Is it because we are using husky? I don't know how to fix it |
I don't think they are related or causing any issues. I see you have joined EddieHub Discord, let's continue the chat there and publish the conclusion here afterwards |
Hello:) I have fixed the issue. The issue was that instead of specifying .prettierignore we were specifying the .gitignore. I have now fixed it. |
CHANGELOG.md
Outdated
* caprover config ([38521e0](https://github.com/EddieHubCommunity/good-first-issue-finder/commit/38521e035edc251675ad28f5914aac477c4c5fae)) | ||
|
||
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ignore this file as it is auto generated
Hello:)
I have integrated prettier in husky