refactor: update to ratatui v0.28 #172
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2024
Open
|
Wait for a release which includes ratatui/ratatui#1226 Until then af67ef0 prevents these glitches from happening. |
EdJoPaTo
changed the title
|
GitHub GUI branch rename pushes it and deletes the old one, killing the PR… hoped for something more useful… 😒 |
|
Wait for a ratatui release which includes ratatui/ratatui#1312 🤡 |
This was referenced Aug 31, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix in unicode-width 0.1.13 introduces buggy behavior in ratatui rendering. MQTT topics which publish with control sequences (like espHome devices on /debug do) cause the rendering to be off. Block borders are rendered on wrong positions and colors leak into wrong positions including the next line. (See ratatui/ratatui#1211)
This should be fixed before updating to unicode-width >=0.1.13 (and therefore ratatui > 0.26).